Skip to content

Fix pyparsing diagnostic warning on Table import#3081

Merged
geruh merged 2 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/fix-pyparsing-warning
Feb 27, 2026
Merged

Fix pyparsing diagnostic warning on Table import#3081
geruh merged 2 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/fix-pyparsing-warning

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Feb 22, 2026

Rationale for this change

Closes #3064

Fix pyparsing warning on import of pyiceberg.table.Table

  • Add a regression test that enables warn_ungrouped_named_tokens_in_collection and verifies the import path stays clean.
  • Remove the parser results-name collision that triggered PyparsingDiagnosticWarning during from pyiceberg.table import Table.

Are these changes tested?

Yes. test fails before the fix commit, and succeeds after

manually verify with

make install
uv run --python 3.13 -- python -Werror -c "from pyiceberg.table import Table"

Are there any user-facing changes?

@kevinjqliu kevinjqliu force-pushed the kevinjqliu/fix-pyparsing-warning branch 2 times, most recently from 8ca2a73 to a38f76e Compare February 23, 2026 00:25
@kevinjqliu kevinjqliu force-pushed the kevinjqliu/fix-pyparsing-warning branch from b8ada5e to c481c57 Compare February 23, 2026 00:31
Copy link
Member

@geruh geruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geruh geruh merged commit 7425bc4 into apache:main Feb 27, 2026
14 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/fix-pyparsing-warning branch February 27, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning from pyparsing when using Table

3 participants